refactor: Common static analysis issues #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.CommonStaticAnalysis?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
JLLeitschuh
reviewed
Nov 3, 2023
Comment on lines
-356
to
-369
| switch (_case.getType()) { | ||
| case Statement: | ||
| if (_case.getStatements().isEmpty()) { | ||
| // Visit a fake empty statement to ensure that the ConditionNode has a true successor | ||
| visit(new J.Empty(randomId(), Space.EMPTY, Markers.EMPTY), p); | ||
| } else { | ||
| visitStatementList(_case.getStatements(), p); | ||
| } | ||
| break; | ||
| case Rule: | ||
| visit(_case.getBody(), p); | ||
| breakFlow.add(currentAsBasicBlock()); | ||
| current = Collections.emptySet(); | ||
| break; |
There was a problem hiding this comment.
Can you elaborate on why what you have is better?
|
@JLLeitschuh Thanks for your review! I ran a recipe which did all these changes. The switch-to-if is due to https://docs.openrewrite.org/recipes/staticanalysis/minimumswitchcases (RSPEC-1301). Not sure I agree with that particular one either... The lost comments are deficiencies of the respective recipes. I can try to fix these. |
Much appreciated. Can you also restore the lost comments in the meantime? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.CommonStaticAnalysis?organizationId=T3BlblJld3JpdGU%3D